search

JohnDoneth / hd44780-driver

Implementation of the embedded-hal traits for the HD44780.
MIT License
37 stars 40 forks source link

Made modules fourbit and eightbit public. #10

Closed irwineffect closed 4 years ago

irwineffect commented 4 years ago

This patch makes the modules fourbit and eightbit public, to allow a user to store the driver into a specific type.

Note that this is necessary to use this crate with the RTFM framework (https://github.com/rtfm-rs/cortex-m-rtfm), where we need to call out the specific type, which isn't possible if these types are private.

JohnDoneth commented 4 years ago

Hi! Thanks for the PR. Could you explain why making the modules themselves public helps to use RTFM? I was under the impression that the types in those modules were already exported publicly.

nils-van-zuijlen commented 4 years ago

As #13 got merged, you may want to rebase to add the new bus module