search

JohnDoneth / hd44780-driver

Implementation of the embedded-hal traits for the HD44780.
MIT License
37 stars 40 forks source link

move to digital::v2 #11

Closed golledge closed 4 years ago

golledge commented 4 years ago

Tested on stm32f302r8 which is not in the example.

JohnDoneth commented 4 years ago

Thanks for the PR! I think we should probably handle the errors instead of ignoring them if possible, even if it is a breaking API change.

golledge commented 4 years ago

Ok, I will have a think about how to it. I am new to rust so any direction is welcome.

golledge commented 4 years ago

Well I have add some error handling. If you want any changes just say.

golledge commented 4 years ago

Hope this is what you were after.

JohnDoneth commented 4 years ago

Closed in favor of #15. Thanks for your work!