search

JohnDoneth / hd44780-driver

Implementation of the embedded-hal traits for the HD44780.
MIT License
37 stars 40 forks source link

Don't consume delay, 2018 Rust, v2 Hal #15

Closed David-OConnor closed 4 years ago

David-OConnor commented 4 years ago

https://github.com/JohnDoneth/hd44780-driver/issues/14

Also, on 2018 edition of rust, and switched to v2 (fallible) embedded hal traits. Note that I haven't yet implemented the error propagation. In other words, so far, we've only replaced the deprecated errors with unused result.

David-OConnor commented 4 years ago

Looks like the work's already done on the error propogation: https://github.com/JohnDoneth/hd44780-driver/pull/11

David-OConnor commented 4 years ago

Updated with @golledge 's code for error propagation. Effectively, a merge of the 2 PRs.

JohnDoneth commented 4 years ago

LGTM 👍 Thanks for this!