HD44780 takes ownership of `Delay`

JohnDoneth / hd44780-driver

Implementation of the embedded-hal traits for the HD44780.

MIT License

37 stars 40 forks source link

HD44780 takes ownership of `Delay` #16

Closed fuchsnj closed 4 years ago

fuchsnj commented 4 years ago

The HD44780 struct takes exclusive ownership of Delay, which makes it impossible to use on devices where Delay can only be created once, and can't be cloned (such as a bluepill board)

It would be nice if the HD44780 struct didn't hold the Delay, and it could be passed into functions as a reference as needed.

JohnDoneth commented 4 years ago

Could you see if using master fixes this issue for you? #15 was merged after the last release.

fuchsnj commented 4 years ago

Yes, master works perfectly. Thanks!