search

JohnDoneth / hd44780-driver

Implementation of the embedded-hal traits for the HD44780.
MIT License
37 stars 40 forks source link

Add Arduino Uno Example #20

Closed JohnDoneth closed 2 years ago

JohnDoneth commented 4 years ago

Adds an example for the Arduino Uno.

Closes #19

Todo

Marcuss2 commented 4 years ago

I have independently got it working. I did it by forking the avr-hal and adding u8 delay_ms. While testing on a UNO clone, I noticed some issues, like cursor not working properly and found that currently, there is only 100 us delay, while the documentation requires 450 us delay. It is especially true for the clear method, which needs even larger delay.

I also made a pull request to implement the u8 delay in AVR-HAL, so I don't think the change from u8 to u16 is needed.

Marcuss2 commented 4 years ago

The u8 delay in AVR-HAL was implemented, so I think just removing those changes from u8 to u16 should be enough at this point.