search

JohnDoneth / hd44780-driver

Implementation of the embedded-hal traits for the HD44780.
MIT License
37 stars 40 forks source link

add async functionality #27

Closed xoviat closed 3 years ago

xoviat commented 3 years ago

This PR adds async functionality. However, it removes the blocking functionality. This is really more of a conversation starter on how both blocking and async should be implemented. Should I copy the async into a new folder, and have them side-by-side. Should there be a configurable feature?

Closes #4.

zacck-zz commented 3 years ago

@martinthuranira this is what we would have had to do ....

JohnDoneth commented 3 years ago

Great work on this!

Should I copy the async into a new folder, and have them side-by-side. Should there be a configurable feature?

I would prefer it to be under a feature flag like you suggested and also have it under it's own async module at the root.

xoviat commented 3 years ago

Waiting on #28

xoviat commented 3 years ago

confirmed on hardware

xoviat commented 3 years ago

update: I went ahead and published 0.0.0 just to get us over the initial hump until 0.1 is released.

xoviat commented 3 years ago

@JohnDoneth is that okay?

JohnDoneth commented 3 years ago

Looks great! Ready to merge?

xoviat commented 3 years ago

I think so.