JohnDoneth / hd44780-driver

Implementation of the embedded-hal traits for the HD44780.
MIT License
37 stars 40 forks source link

Add set_cursor_pos_unchecked method. #51

Closed cr1901 closed 4 days ago

cr1901 commented 9 months ago

In light of set_cursor_pos working exclusively in terms of screen coordinates, I needed a function that let me set offscreen addresses to values to work with scrolling.

ColinTimBarndt commented 2 weeks ago

54 would solve this problem by allowing these off-screen coordinates (and still checking them).

cr1901 commented 1 week ago

If it means that I can stop using my own fork of the driver, I'm not against learning your API changes (though your changes seem like they'd take longer to be reviewed :P).

JohnDoneth commented 4 days ago

Closing now that https://github.com/JohnDoneth/hd44780-driver/pull/54 merged and should allow for this.