JohnEarnest / Octo

A Chip8 IDE
MIT License
682 stars 55 forks source link

Any interest in a typescript and npm PR? #91

Closed zZeck closed 5 years ago

zZeck commented 5 years ago

Forked octo about a week ago. Added npm package management, converted the code to typescript, and used webpack to build. Getting close to decent state I think. Doing manual testing and resolving issues.

Any interest in those changes?

In progress here: https://github.com/zZeck/Octo/tree/typescript

Never tried to contribute to a project before, so hopefully I'm asking this in the right place...

Really like octo. Helped me sort out if my own chip8 interpreter had problems or if I was just seeing ROM quirks.

JohnEarnest commented 5 years ago

Hi, @zZeck! Glad to hear you're enjoying Octo!

I'm not currently interested in moving mainline Octo to TypeScript. However, if you do find any Octo bugs while tinkering with your fork (and I'm sure there are still plenty lurking in there), I'd be happy to accept pull requests. Small individual patches that are easy for me to review are greatly appreciated.

Also, If you aren't already aware, some friends and I host an annual October-long game jam centered around Chip8- If you're interested in participating, I can ping you in late September when we're getting everything ready.

zZeck commented 5 years ago

Fast response! I was thinking the change might be a bit dramatic, but I figured I'd ask.

Definitely will make PRs for any issues I find. Plan to add automated tests after I get the basics done. Might turn up some stuff.

The octo-ber jam videos were very interesting. Watched all those. Read through most of the something awful thread as well. Useful information. Surprisingly difficult to find information about chip8 quirks.

No idea what I'll be doing around September. If I get something together by then, I'll definitely reach out if it's interpreter related, or submit the program it if it's a chip8 game/demo.

Thanks for all the work you've put into this project!