search

JohnEarnest / ok

An open-source interpreter for the K5 programming language.
MIT License
585 stars 73 forks source link

Add read json capability to CLI interface #86

Closed ab5tract closed 4 years ago

ab5tract commented 4 years ago

This is a hopefully decent opening to supporting JSON in the CLI interface and to a discussion about how best to do that.

JohnEarnest commented 4 years ago

Ok, I'm getting flooded with notifications from all these commits. I'd appreciate it if you slowed down a bit and reserved pull requests for a polished, working, proposed change. Trying to have a discussion in revision-controlled comments is really fighting against the tools we're using here.

If you have questions about how to do something or how something works, you could use an issue, write annotations on your commit from the github side, or even just send me an email.

ab5tract commented 4 years ago

Ok, I'm getting flooded with notifications from all these commits. I'd appreciate it if you slowed down a bit and reserved pull requests for a polished, working, proposed change. Trying to have a discussion in revision-controlled comments is really fighting against the tools we're using here.

If you have questions about how to do something or how something works, you could use an issue, write annotations on your commit from the github side, or even just send me an email.

I disabled emails from Github for reasons like this, so I understand the issue. I'll refrain from initiating a PR until "ready" and find some other means of figuring out when that criteria is met.

So: 1) Do you want to have 1: understand directories as well as JSON objects stored as files? 2) Should the tok function be able to translate all valid JSON? If so then it appears that there needs to be some decision made around how to handle null objects.

ab5tract commented 4 years ago

Closing this PR. Will resubmit something more fully developed.