JohnGiorgi / seq2rel-ds

This is a companion repository to seq2rel (https://github.com/JohnGiorgi/seq2rel) which aims to make it easy to generate training data.
5 stars 1 forks source link

Better entity hinting #26

Closed JohnGiorgi closed 3 years ago

JohnGiorgi commented 3 years ago

The entity hinting introduced in #23 had a bunch of problems. I went through very carefully and addressed each of them. I also added tests for each of the edge cases. Finally, I confirmed this leads to a big boost in performance (+20% on GDA), suggesting that the entity hinting is working.