JohnLCaron / egk-ec

Electionguard kotlin on elliptic curves
MIT License
0 stars 0 forks source link

ContestData not complete #55

Open JohnLCaron opened 6 months ago

JohnLCaron commented 6 months ago

Consider this feature incomplete. Not fully specified, will not agree with another implementation. Mostly matters for the Verifier, perhaps a flag to ignore is needed.

See https://github.com/votingworks/electionguard-kotlin-multiplatform/issues/155

JohnLCaron commented 6 months ago

Is there something needed in the ballot validation around writeins or contest data?

JohnLCaron commented 6 months ago

HashedElGamalCiphertext is not tested enough, esp being compliant with the spec. Comparing to another implementation would be best.

Probably dont need numBytes:

data class HashedElGamalCiphertext(
    val c0: ElementModP,
    val c1: ByteArray,
    val c2: UInt256,
    val numBytes: Int // TODO not sure if this is needed
)