JohnLetnev / airhead-research

Automatically exported from code.google.com/p/airhead-research
0 stars 0 forks source link

Addition of Purandare & Petersen S-Space, Vector refactoring, Clustering additions #37

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:

Three major updates:
1. Addition of Purandare & Petersen S-Space code
2. Initial refactoring of the Vectors class (VectorMath)
3. Addition of HAC and Cluto Clustering classes

When reviewing my code changes, please focus on:

1. The P&P class is big, but should be reasonable clear to follow.  Please
let me know if some parts seem unusual or could be improved.

2. If I am missing any updates/improvements to other Matrix classes based
on the changes to the Vectors class.

3. Whether we could standardize the API for the clustering classes.  This
might be solved with a package-level javadoc, or just by convention.  At
this time, I'm still against creating an interface, given the variety of
APIs we expect.

4. P&P uses some bigram statistics.  Eventually, I'd like to fold these in
to a separate utility.  We have that Bigram-extractor code, which isn't
included.  Ideally, there should be something for dealing with n-way
contingency tables, but at the moment, I only have code for 2-way (i.e.
bigram) tables.   If you think we might want to fold this in now, or at
least start the refactoring let me know.  Otherwise, we can do it in a
separate merge.

5. Ignore any hermit-related classes.  These won't be included in the merge.

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by David.Ju...@gmail.com on 3 Dec 2009 at 10:21

GoogleCodeExporter commented 9 years ago
Set review issue status to: Started

Original comment by FozzietheBeat@gmail.com on 3 Dec 2009 at 5:12

GoogleCodeExporter commented 9 years ago
Set review issue status to: Done

Original comment by David.Ju...@gmail.com on 8 Dec 2009 at 12:30