JohnLouderback / GDB

Generic Data Binder (GDB) for jQuery is a framework agnostic and extremely easy to use 2 way data binder. GDB binds views and models in realtime with live two-way binding and no hefty framework necessary.
http://gdb.thewebdev.guru/
Apache License 2.0
87 stars 11 forks source link

render selector bug #18

Closed ranmacar closed 10 years ago

ranmacar commented 10 years ago

works with: var selector=$(options.rootElementSelectorString).find("[" + options.dataBindToAttr + "],[" + options.dataWatchingAttr+"]");

JohnLouderback commented 10 years ago

Hi @ranmacar I'm not sure what your question is. Could you please explain further?

ranmacar commented 10 years ago

options.rootElementSelectorString is getting set to a DOM element, which results in 'Syntax error, unrecognized expression: [object HTMLBodyElement] [data-bindto],[data-watching]'. (DOM + 'string' = no go) Or am I missing something? :)

JohnLouderback commented 10 years ago

Interesting. I apologize for the inconvenience. I'll investigate this. I'm currently fighting a bad cold, but I'll try to tackle this as soon as possible.

ranmacar commented 10 years ago

No problem. Thanks for the work so far, looks interesting. Get well soon!

JohnLouderback commented 10 years ago

I've made a commit that should remedy the issue, but I have not yet been able to test it. Let me know if this fix improves your experience.

Thanks, -John

JohnLouderback commented 10 years ago

I've been told this issue has been resolved. Let me know if you experience the issue still and reopen this ticket. If you have any other issues using GDB, please let me know.

ranmacar commented 10 years ago

Yeah, works for me too. Thanks.