JohnMarzulli / StratuxHud

Heads Up Display for use with Stratux. Designed for reflective HUD screens, intended for traffic call outs.
https://johnmarzulli.github.io/StratuxHud/
GNU Lesser General Public License v3.0
120 stars 22 forks source link

Initial port to Python 3.7.2 #31

Closed N129BZ closed 5 years ago

N129BZ commented 5 years ago

John, I finally figured out how to do Git forking & branching. Anyway, this is the result of running the original .py files through the 2to3 porting tool found at https://docs.python.org/2/library/2to3.html

I then debugged each .py file using Pylint to help resolve any import issues. I added # pylint: disable=[warning] statements as necessary to help me resolve what were the actual errors due to changes in 3.7.

I added an underscore to the beginning of a variable name if that variable was not actually used, like when extracting values using a tuple, but only one of the values is actually being used. I'm not sure if those warnings are new to 3.7 or not, but by using an underscore as the first character it keeps pylint from filling up the output window.

Thanks for the opportunity to assist.

Brian Manlove

P.S. - I had to create a new account in Github because I think I messed up my original Zenbuilder account. The new acccount is user name: N129BZ email: brianmanlove@gmail.com

JohnMarzulli commented 5 years ago

Thank you. This is going to take a few days to look through, and I am hoping to flight test it as well.

N129BZ commented 5 years ago

John - I've been testing in a couple Linux distros and I think that Python 3.7.2 is a little bit too cutting edge, I had trouble getting a pkg to install correctly. What I found was that 3.6 is actually included in several Debian distros including ubuntu and mint. I changed the minimum allowed value to 3.6 and the code runs fine without any other changes.

JohnMarzulli commented 5 years ago

Can you re-target the PR to 1.4_beta please. I want to be very protective of the Master branch.

Also, for a change this large and signifigant, we will want to bump the version number to 1.4.

The setup directions will also need some attention to update for the new version of Python.

Regarding which version of Python, my goal is to target whatever is in the latest version of Raspbian as that is the main/intended platform.

N129BZ commented 5 years ago

I will re-target, still trying to get a better handle on git processes... also re-checking the latest raspbian for it's included python version

JohnMarzulli commented 5 years ago

@N129BZ - Have you been able to retarget, or create a new PR to target the 1.4B branch instead?

N129BZ commented 5 years ago

John - I re-targeted the PR to the new beta branch. Sorry about the delay. I've finally been able to go flying here, hadn't been up since before Christmas. I was down with a radio issue for a month and then it rained every day for a month. We've now had sunshine 3 days in a row.

JohnMarzulli commented 5 years ago

No worries. I finally got up recently after a long month of bad WX. [Image]

Get Outlook for iOShttps://aka.ms/o0ukef


From: Brian A Manlove notifications@github.com Sent: Tuesday, February 26, 2019 8:56 PM To: JohnMarzulli/StratuxHud Cc: John Marzulli; Comment Subject: Re: [JohnMarzulli/StratuxHud] Initial port to Python 3.7.2 (#31)

John - I'm working on this... I've finally been able to go flying here, hadn't been up since before Christmas. I was down with a radio issue for a month and then it rained every day for a month. We've now had sunshine 3 days in a row. Sorry about the delay.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/JohnMarzulli/StratuxHud/pull/31#issuecomment-467724208, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWAxbOAImKfKD4MTzyy8NuY1Li85mC3Qks5vRg_igaJpZM4a4SWL.