search

JohnMcLear / draw

A real time collaborative drawing tool using nodejs, socket.io & paper.js
Apache License 2.0
482 stars 158 forks source link

Uploaded image not persisting... #179

Closed theoryshaw closed 9 years ago

theoryshaw commented 10 years ago

video demonstrates the issue: https://dl.dropboxusercontent.com/u/7117445/temp/image%20gone.mpg

Happens on all new instances, but this is the one i used for this video: http://sketch.openingdesign.com/d/1toeOwALfP

Image uploaded: https://dl.dropboxusercontent.com/u/7117445/temp/test.jpg

JohnMcLear commented 10 years ago

Unable to replicate on my local instance

JohnMcLear commented 10 years ago

Can replicate on remote instance, hrm

JohnMcLear commented 10 years ago

I'd suggest debugging by running etherdraw in console IE 

sudo /etc/init.d/etherdraw stop
cd %etherdrawhome% (whatever that is for you)
bin/run.sh

Then when you upload an image it should give you the error.

Alternatively if you want I can jump on and take a look.

theoryshaw commented 10 years ago

could you please have a look? thanks.

JohnMcLear commented 10 years ago

Error is this:

/home/ubuntu/draw/node_modules/paper/dist/paper-node.js:4821
            ctx.drawImage(element,
                ^
Error: Image given has not completed loading
    at Raster.Item.extend._draw (/home/ubuntu/draw/node_modules/paper/dist/paper-node.js:4821:8)
    at Raster.Base.extend.draw (/home/ubuntu/draw/node_modules/paper/dist/paper-node.js:3954:8)
    at Layer.Item.extend._draw (/home/ubuntu/draw/node_modules/paper/dist/paper-node.js:4097:11)
    at Layer.Base.extend.draw (/home/ubuntu/draw/node_modules/paper/dist/paper-node.js:3954:8)
    at Project.PaperScopeItem.extend.draw (/home/ubuntu/draw/node_modules/paper/dist/paper-node.js:2542:14)
    at CanvasView.View.extend.update (/home/ubuntu/draw/node_modules/paper/dist/paper-node.js:10552:11)
    at CanvasView.Base.extend.draw (/home/ubuntu/draw/node_modules/paper/dist/paper-node.js:10468:8)
    at progress_external_path (/home/ubuntu/draw/server.js:422:16)
    at Socket.<anonymous> (/home/ubuntu/draw/server.js:180:5)
    at Socket.emit [as $emit] (events.js:106:17)
JohnMcLear commented 10 years ago

https://github.com/paperjs/paper.js/issues/520

theoryshaw commented 10 years ago

theoryshaw commented 10 years ago

Thanks @JohnMcLear

theoryshaw commented 9 years ago

Dooo... it seems to be rearing its ugly head again. Same with you?

theoryshaw commented 9 years ago

randomly happened upon this: http://stackoverflow.com/questions/544993/official-way-to-ask-jquery-wait-for-all-images-to-load-before-executing-somethin/545005#545005

could this be the issue?

JohnMcLear commented 9 years ago

Could be, haven't had any time to look at it further yet though ;\ Give it a go and see if it fixes it?

theoryshaw commented 9 years ago

https://www.bountysource.com/issues/4212799-uploaded-image-not-persisting

theoryshaw commented 9 years ago

Hey John, any insight into this bug lately?

JohnMcLear commented 9 years ago

Afaik it's fixed, have you tested latest version?

theoryshaw commented 9 years ago

yeah, pulled your latest branch changes over and restarted http://sketch.openingdesign.com

JohnMcLear commented 9 years ago

http://sketch.openingdesign.com/d/HPIUlyFDWl seems to be working okay?

JohnMcLear commented 9 years ago

I can't replicate on latest version. Can you?

On 20 May 2015 14:28, Ryan Schultz notifications@github.com wrote:

Hey John, any insight into this bug lately?

— Reply to this email directly or view it on GitHubhttps://github.com/JohnMcLear/draw/issues/179#issuecomment-103888838.

theoryshaw commented 9 years ago

Hey, it's weird, it seems to be working now the 2nd time i tested after pulling your changes. :\