search

JohnMcLear / draw

A real time collaborative drawing tool using nodejs, socket.io & paper.js
Apache License 2.0
482 stars 158 forks source link

Small fixes for non-root url location #238

Closed KickerTom closed 8 years ago

KickerTom commented 8 years ago

As described in issue #236, I had problems when the root path of the url was not empty (etherdraw not running on dedicated address). These changes seems to fix that. Also added a fix for non-working background toggle button.

JohnMcLear commented 8 years ago

Good spot and good fixes! Thanks :)

rugk commented 8 years ago

Ah same issues I also had to fix, https://github.com/JohnMcLear/ep_markdown/pull/17... :smiley:

@JohnMcLear Next time you should really make sure to use the relative paths...

rugk commented 8 years ago

Can this patch please also be included in the master branch?

As a fix this is quite useful...

rugk commented 8 years ago

So I "ported" the PR, see other PR.

JohnMcLear commented 8 years ago

Open a pull request

On 11 May 2016 9:51 p.m., rugk notifications@github.com wrote:

Can this patch please also be included in the master branch?

As a fix this is quite useful...

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHubhttps://github.com/JohnMcLear/draw/pull/238#issuecomment-218586176

rugk commented 8 years ago

Already did. :smile:

JohnMcLear commented 8 years ago

Nice thanks done

On 11 May 2016 10:40 p.m., rugk notifications@github.com wrote:

Already did. [:smile:]

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHubhttps://github.com/JohnMcLear/draw/pull/238#issuecomment-218598694