JohnMcLear / ep_draw

Etherpad plugin for Etherdraw
Other
15 stars 22 forks source link

my art is not shared #2

Closed quenenni closed 9 years ago

quenenni commented 11 years ago

The drawing part works well, but it's not shared. I mean if I draw something, the other users don't see my drawing and vice-versa.

I see nothing in the logs.

Etherpad v1.2.9

JohnMcLear commented 11 years ago

Check the client consoles for errors

quenenni commented 11 years ago

No errors in the console (with INFO level) Nothing is written in the console when I draw something.

But I noticed when I draw something in srWare Iron (a fork of Chromium), it appears in FF. But when I draw something in FF, nothing appears in Iron.

In the JS console in Iron, I have this error: XHR finished loading: "http://draw.etherpad.org/socket.io/1/?t=1363827646712". Error during WebSocket handshake: 'Connection' header value is not 'Upgrade' draw.etherpad.org:1 No errors in the FF Js console.

Did you try your plugin in chromium (or chromium like web browsers)?

PS: A button to clean/erase the drawing would be great. Without it, the only way to start a new one is to reload the page.

JohnMcLear commented 11 years ago

Firefox doesn't appear to work.

Feel free to create feature requests. I have no intention of working on this in the next 6 months at least.

quenenni commented 11 years ago

I missed the error in the FF (iceweasel)) Js console: Iceweasel can't establish a connection to the server at ws://draw.etherpad.org/socket.io/1/websocket/K02e9foBcMe3jtkxNZa9.

this.websocket = new Socket(this.prepareUrl() + query);

socket.io.js (ligne 2371) I guess that's the problem you're talking about. Pity.

For the feature request, if I have to do that in the 'Pull request' page, I'm afraid I can't create a new one. I don't see any button to do that (like for an issue).

Do I have to do something more than subscribe to the github site?

JohnMcLear commented 11 years ago

Learn how to use git

-----Original Message-----

From: quenenni Sent: 21 Mar 2013 02:10:52 GMT To: JohnMcLear/ep_draw Cc: John McLear Subject: Re: [ep_draw] my art is not shared (#2)

I missed the error in the FF (iceweasel)) Js console: Iceweasel can't establish a connection to the server at ws://draw.etherpad.org/socket.io/1/websocket/K02e9foBcMe3jtkxNZa9.

this.websocket = new Socket(this.prepareUrl() + query);

socket.io.js (ligne 2371) I guess that's the problem you're talking about. Pity.

For the feature request, if I have to do that in the 'Pull request' page, I'm afraid I can't create a new one. I don't see any button to do that (like for an issue).

Do I have to do something more than subscribe to the github site?


Reply to this email directly or view it on GitHub: https://github.com/JohnMcLear/ep_draw/issues/2#issuecomment-15215740

quenenni commented 11 years ago

I'll look more deeply at git. I only know the basics and I know we can do much much more.

JohnMcLear commented 11 years ago

btw if you host your own ep_draw server then you wont have the FF error, it's a 30 second fix tbh, just need to remove websocket from the array of transports.

quenenni commented 11 years ago

Indeed, it works in FF when installing the draw server locally.

What I did (in case someone else is interested to do the same): git clone git://github.com/JohnMcLear/draw.git etherpad-draw cd etherpad-draw cp -a settings.json.template settings.json !!!! The port option in settings.json is not the one used by the server. !!! Go in server.js and change this if you want another port: var port = 3000;

Now, maybe it's simpler to remove websocket from the array of transports, but as I was thinking maybe another plugin may need it, I preferred to edit the file "ep_draw/static/js/draw.js" to change the value of the iframe source to my server (line 24 in this version).

Then, start your etherpad-lite server before the draw server. If not, I had error 503 when accessing my pads.

And now, it works perfectly in FF too.