search

JohnMcLear / ep_draw

Etherpad plugin for Etherdraw
Other
15 stars 22 forks source link

Drawing only possible on a fraction of the screen #30

Closed c0dev0id closed 4 years ago

c0dev0id commented 4 years ago

I really like the idea. Especially with webrtc in etherpad, this makes a whole new form of collaboration possible.

In my installation ep_draw only allows to draw to the top fraction of the screen. Test here: https://pad.new.uugrn.org/p/drawtest

image

Draw itself works fine... see: https://draw.uugrn.org

c0dev0id commented 4 years ago

Oh, I see this has been fixed at https://github.com/JohnMcLear/ep_draw/issues/28 ... sorry for the noise. I'll update.

c0dev0id commented 4 years ago

No - it still does happen. I'm on ep_draw commit 8ed9034f439b6da6d396d65e84028f7213e9177f and etherpad-lite commit https://github.com/ether/etherpad-lite/commit/901a3f396e1b3fffda940e06f23394ef55b5c992, cleared the browser cache, restarted etherpad-lite... no change.

JohnMcLear commented 4 years ago

I'm gonna try look at this today.

JohnMcLear commented 4 years ago

Fixed. Please update :)

JohnMcLear commented 4 years ago

Btw what happened here was Etherpad went 1.8.3 and I thought I patched it but my patch was on another server and it was a 2 line patch and I forgot to bring both lines of fixes over.. These were busy days and because ep_draw and etherdraw both need a rewrite I'm just quickly throwing stuff out to keep things moving.

Sayao32 commented 4 years ago

Working great with lastest update :) Thanks a lot for your work !

c0dev0id commented 4 years ago

Yep, works! Thank you very much!