search

JohnMcLear / ep_draw

Etherpad plugin for Etherdraw
Other
15 stars 22 forks source link

(untested) added autoFullscreen option #37

Closed AliKarpuzoglu closed 4 years ago

AliKarpuzoglu commented 4 years ago

Fix for #36

immediately open in fullscreen when clicking the draw icon.

In the readme we should add:

To automatically open the pad in fullscreen

    "ep_draw": {
        "autoFullscreen": true
    }
rs4231199 commented 4 years ago

hey @AliKarpuzoglu I spent some time looking at your PR. I think It is failing because of some permissions. Have a look at this.

JohnMcLear commented 4 years ago

Merging in attempt to run test properly. This will probably want/need test coverage too? :) Not sure if that is in scope.

Note that there are currently no tests in ep_draw so you would need to bring them in, for reference see ep_headings2 for how to implement tests.

Currently ep_draw is just testing Etherpad functionality when ep_draw is installed. This tests Etherpad, not ep_draw.

JohnMcLear commented 4 years ago

Passing now... Sorry but to get tests to run I have to have permission of dev has to be a core Etherpad dev.