search

JohnMcLear / ep_draw

Etherpad plugin for Etherdraw
Other
15 stars 22 forks source link

continuing autoFullscreen option #40

Closed rs4231199 closed 4 years ago

rs4231199 commented 4 years ago

continuing #37

I tested the code. It initially didn't work as expected. But now it's working alright.

rs4231199 commented 4 years ago

@JohnMcLear Can you confirm that it's working alright with option autoFullscreen set true and false.

JohnMcLear commented 4 years ago

@rs4231199 If you want to confirm something, include test coverage.

You will need to wait for OP to confirm it meets his/her requirements.

AliKarpuzoglu commented 4 years ago

The auto Fullscreen looks to be working. Did anyone try the other types to check if we didn’t break anything?