search

JohnMcLear / ep_draw

Etherpad plugin for Etherdraw
Other
15 stars 22 forks source link

Add boolean showChat to draw.js #6

Closed tranek closed 9 years ago

tranek commented 11 years ago

Add a showChat = false query to the EtherDraw url so that we can add a chatbox to EtherDraw and not have two chat boxes for the Etherpad ep_draw plugin.

https://github.com/JohnMcLear/draw/issues/22

JohnMcLear commented 11 years ago

I think stuff like chat should go into some sort of plugin framework and/or we leverage a third party. We don't want to have to maintain a chat client as well as a drawing client

tranek commented 11 years ago

Etherpad's chat isn't a plugin that we could reuse is it?

JohnMcLear commented 11 years ago

It could/should be, I guess..

tranek commented 11 years ago

LOL. More work? XD

JohnMcLear commented 11 years ago

I will ponder this and take a look to see how difficult it will be to do.. I think the main issue is going to be accessing the socket and dealing with auth.

tranek commented 11 years ago

Okay! Chat isn't a major thing right now. Our main concern is crashing the server! Ugh. But I'm glad that it'll be in the back of your mind :)

JohnMcLear commented 11 years ago

An outcome of doing it by making chat a plugin would be that currently etherpad wouldn't put through it's minification process so it would adversely affect performance ;\ This is a bad thing..

We could potentially do chat as an npm module still but afaik all client side code would still be replicated, heh, kinda pointless right as nearly all of the code is client side code...

So yea, I suggest we wait on this :)

tranek commented 11 years ago

I'm fine with waiting for now!

JohnMcLear commented 9 years ago

I'm not going to work on this, Etherpad already has chat and that is what should be used :)