search

JohnMcLear / ep_draw

Etherpad plugin for Etherdraw
Other
15 stars 22 forks source link

Tie drawings to pads (fixes #7) #9

Closed owenversteeg closed 11 years ago

owenversteeg commented 11 years ago

I tested it out already, works perfectly.

owenversteeg commented 11 years ago

You can see this active at http://infinitynote.com.

I'm running a somewhat modified Etherpad there, for fun try out doing math like typing sqrt(2) and then type an equals sign

JohnMcLear commented 11 years ago

Service Temporarily Unavailable

JohnMcLear commented 11 years ago

Have you tested this with pads that have parameters set in the URL IE http://foo.com/p/test?toc=true

JohnMcLear commented 11 years ago

Added you as a collaborator so you can merge your own PRs

owenversteeg commented 11 years ago

Hah, it never seems to stay up. I'll take a look at the logs, I think it has something to do with the obscene number of plugins I have installed.

I just tested it with pads that have parameters in the URL - it works fine. It does pass the params on, unencoded, to draw.etherpad.org; however, this doesn't seem to be a problem - draw.etherpad.org ignores URL params apparently.

However, this seemed like a better-safe-than sorry situation, so I added a line to remove any URL params if they exist; I just tested it and it works fine. I'll go ahead and merge it now.