search

JohnMcLear / ep_page_view

Etherpad Page View plugin
https://npmjs.org/package/ep_page_view
14 stars 17 forks source link

Page break on disabled "page view" #15

Closed Gared closed 10 years ago

Gared commented 10 years ago

If you have disabled the "page view" on a pad, you still get the "page break div". Deactivate "page view" on this pad to see the issue: https://beta.etherpad.org/bTyi0zXdba

JohnMcLear commented 10 years ago

Pretty sure I fixed that a while back.. beta.etherpad.org might not be runnign the latest v of the plugin.. Please check...

Gared commented 10 years ago

I think the bug is back again. On my local server I've tested the problem with the latest version of this repo. Will try to fix this

JohnMcLear commented 10 years ago

I fixed it here: https://github.com/ether/ep_page_view/commit/ee1c41ccfa25c9d70458865b210d02cb3db84ad6

Make sure you have that commit

Gared commented 10 years ago

I have that commit. Still buggy

JohnMcLear commented 10 years ago

works fine for me..

JohnMcLear commented 10 years ago

You know you are supposed to be able to see 2 thin lines right? They identify that it's a page break..

Gared commented 10 years ago

Yeah, but if you disable page view you shouldn't see these lines, should you?

JohnMcLear commented 10 years ago

Yes. I restyled them so they aren't as offensive looking.

Gared commented 10 years ago

You're talking about manually page breaks right? I have problems with the automatically added ones

JohnMcLear commented 10 years ago

Yea, ah..

JohnMcLear commented 10 years ago

Yea I confirm that bug.

JohnMcLear commented 10 years ago

git pull and test.

Gared commented 10 years ago

Thanks your commit is working, but I've also done some work on it. See the related pull request if your happy with it. This commit also fixes my problems