Checking 'Page View' setting when URL param 'pageview' is 'true'

[lpagliari]

It seems that 'Page View' checkbox is not being checked when using the URL param 'pageview'.

To reproduce:

• open a pad;
• uncheck 'Page View' setting (to make sure the cookie is not true for PV property);
• reload pad with pageview=true as param on the URL;

Expected: 'Page View' setting should be checked Actual: setting is not checked

This PR should fix that. Tested on Chrome and FF.

[JohnMcLear]

I think it's being overridden by a user defined cookie? Which would kinda be what you want no?

[lpagliari]

If that is the case, we need to fix the code too (in another way, of course): currently if I have the cookie set to not show PV and use the URL param as true, it's enabling PV but not checking the checkbox, which is also inconsistent.

Regarding the precedence between URL param and cookie, I thought URL param should have the higher one, but now I'm not sure. Thinking as a user, I would be mad to have to uncheck PV setting every time I opened a pad and wanted PV to be disabled.

Thoughts?

[JohnMcLear]

Agreed

[lpagliari]

Sorry, so which direction should I take? Make URL param have higher precedence, or the cookie?

[JohnMcLear]

I'd say the cookie so we give more control to the user but we should allow it to be "forced" by the site admin if required. Afaik we already allow for it to be forced in settings.json

[lpagliari]

So on this scenario:

• cookie has PV disabled;
• URL has pageview=false;
• but settings.json has "ep_page_view_default" : true;

When user opens a pad, should PV be enabled? I would expect so, but wanted to confirm.

[JohnMcLear]

If the plugin sets it on by default but the user has turned off page view and the URL sets pageview to off then it shouldn't show as page view.

[lpagliari]

OK, got it, @JohnMcLear . cff5480 should address that.