search

JohnMcLear / ep_page_view

Etherpad Page View plugin
https://npmjs.org/package/ep_page_view
14 stars 17 forks source link

Broken CSS regression #3

Closed lkraav closed 10 years ago

lkraav commented 10 years ago

screenshot from 2013-12-01 20 56 05

Last 0.3.0 seems to have broken some basics significantly

  1. There is no scrollbar to navigate the document by.
  2. Bottom of the document is cut off
JohnMcLear commented 10 years ago

Sounds probable, I need to rewrite.. will publish old version.. Published 0.3.1 based off old code.

lkraav commented 10 years ago

Right. Stability is restored, too bad we now don't have the page break functionality which was the upgrade magnet for me.

JohnMcLear commented 10 years ago

I should be able to get it back in within the next 24 hours anyways..

I didn't like how I did it before, it felt wrong

From: Leho Kraav [notifications@github.com] Sent: 01 December 2013 19:18 To: ether/ep_page_view Cc: John McLear Subject: Re: [ep_page_view] Broken CSS regression (#3)

Right. Stability is restored, too bad we now don't have the page break functionality which was the upgrade magnet for me.

— Reply to this email directly or view it on GitHubhttps://github.com/ether/ep_page_view/issues/3#issuecomment-29580629.

JohnMcLear commented 10 years ago

Leho, got time to test a fixed version?

https://github.com/ether/ep_page_view/tree/version2

cd node_modules
git clone https://github.com/ether/ep_page_view.git
git checkout version2

Will get you it.