JohnMcLear / ep_page_view

Etherpad Page View plugin
https://npmjs.org/package/ep_page_view
14 stars 17 forks source link

Toolbar area missing, button overlay document #5

Closed lkraav closed 10 years ago

lkraav commented 10 years ago

screenshot from 2013-12-21 23 46 36

Still, much better than 0.3.0 was :)

JohnMcLear commented 10 years ago

Good catch will investigate ASAP

JohnMcLear commented 10 years ago

I just tried to replicate but I'm unable to.

What version of Etherpad? What version of ep_page_view? What browser?

lkraav commented 10 years ago

1.3.0 0.4.9 Linux+Firefox 26.0/Chrome 27

Other plugins:

adminpads Gives the ability to list and administrate all pads on admin page 0.0.5
align Add Left/Center/Right/Justify to lines of text in a pad 0.0.6
cursortrace Show cursor/caret movements of other users in real time 2.0.4
headings Adds heading support to Etherpad Lite. 0.1.6
hide_referrer Don't pass the referring URL to third parties. This handles the security/privacy issue where you don't want the third party service to know your pad URL. Improves Privacy. 0.0.7
page_view Add support to do 'page view', with a toggle on/off option in Settings, also Page Breaks with Control Enter 0.4.9
scrollto Scroll to a specific line number based on a parameter of lineNumber in the URL IE http://test.com/p/foo#lineNumber=10 -- Users can click on the line number to get a link 0.0.5
show_whitespace Show trailing whitespace 0.0.2

JohnMcLear commented 10 years ago

Okies will test w/ those other plugins enabled, afaik none of them modify innerbody but will need to test.. Can you test just ep_page_view by itself to see if the problem persists?

JohnMcLear commented 10 years ago

Also any settings for ep_page_view maybe ep_page_view_default or so?

lkraav commented 10 years ago

Yes it is my default.

JohnMcLear commented 10 years ago

Ah yes

ep_page_view_default : true

is the cause :)

JohnMcLear commented 10 years ago

Resolved https://github.com/ether/ep_page_view/commit/4540dd327c7be63ae99e39372252692fa5273b61