JohnNub / pe

0 stars 0 forks source link

Failing to save file does not prevent todo list from getting populated. #7

Open JohnNub opened 3 years ago

JohnNub commented 3 years ago

If there is an issue saving the file, the user should be warned that their data may be lost. Saying "something went wrong" doesn't tell the average user who might not know what this message implies. It should either display a warning about data loss or prevent the adding of items to the list to prevent a desync between the program and the filesystem.

image.png

This was tested by forcing write deny on the folder permissions, but there are other reasons that an IO operation can fail in normal use on other computers.

image.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: A write operation can fail under normal use of the software. Even though the use case here was simulated, it is a legitimate possibility to encounter a write failure. Since the file is human editable, another editing program may reserve or lock the file preventing your software from opening it, falls under https://github.com/nus-cs2113-AY2021S1/forum/issues/117 which considers editing as a valid bug.

Developer is trying to abuse the transparency provided by the tester (providing the replication method) to assert that it is not in scope. No scope was given to specify that the program would have an exclusive lock on all its file, neither was that implemented in their actual application.