JohnReedLOL / scala-trace-debug

Macro based print debugging. Locates log statements in your IDE.
https://github.com/JohnReedLOL/pos
MIT License
115 stars 5 forks source link

Please consider publishing to Maven Central #20

Closed alexeyr closed 7 years ago

alexeyr commented 8 years ago

It isn't a problem for a library to add resolvers += "johnreed2 bintray" at "http://dl.bintray.com/content/johnreed2/maven" (by the way, isn't the equivalent needed for Maven as well)? It is a bit worse to require everyone who depends on this library to add it too. I was thinking how I could avoid this problem, but can't find a reliable way :( Though SBT does allow to make this dependency for SNAPSHOT versions only.

See https://bintray.com/docs/usermanual/uploads/uploads_syncingartifactswithmavencentral.html and https://blog.bintray.com/2014/02/11/bintray-as-pain-free-gateway-to-maven-central/ for explanation how to upload from Bintray to Maven Central.

JohnReedLOL commented 8 years ago

I had no idea someone else depended on this library, lol. I have other things to do now, but if it isn't too much trouble I'll do it.


Side note: I'm thinking of redoing this to make the variables names shorter:

Debug.trace("Foo") --> Err("Foo") Debug.traceStdOut("Foo") --> Out("Foo")

SDebug.traceCode("Foo") --> ErrCode("Foo") SDebug.traceCodeStdOut("Foo") --> OutCode("Foo")

Debug.check(1 == 1) --> Check(1 == 1) Debug.checkStdOut(1 == 1) --> CheckOut(1 == 1)

Debug.assrt(1 == 1) --> Assert(1 == 1) Debug.assertStdOut(1 == 1) --> AssertOut(1 == 1)

alexeyr commented 8 years ago

Well, we don't, because of this issue :) Though your library is mentioned at https://github.com/typesafehub/scala-logging, so I wouldn't be surprised if people do depend on it.

For main work project we probably won't, because we are trying to reduce the dependencies, we'll probably just have our own macros adapted to our requirements. But for my personal projects, I would avoid having my own version as well.

Also a side note: would you object if I used scala.trace group ID for https://github.com/alexeyr/scala-trace-entry-exit?

JohnReedLOL commented 8 years ago

That's fine.

JohnReedLOL commented 8 years ago

@alexeyr Can you help me out? In "bintray" it says

"Developer information missing Missing Signature: '/com/github/johnreedlol/scala-trace-debug_2.10/3.0.0/scala-trace-debug_2.10-3.0.0-sources.jar.asc' does not exist for 'scala-trace-debug_2.10-3.0.0-sources.jar'"

alexeyr commented 8 years ago

Have you set up signing as described in https://blog.bintray.com/2013/08/06/fight-crime-with-gpg/?

timcharper commented 7 years ago

@JohnReedLOL it isn't too difficult; the worst part is getting a maven central org setup.

Start here:

http://central.sonatype.org/pages/producers.html#individual-projects-open-source-software-repository-hosting-ossrh

Once done, I could help you with updating your build.sbt et al

JohnReedLOL commented 7 years ago

@alexeyr @timcharper Hey guys, I am really close. I uploaded to bintray and got the gpg keys set up in the 4.0 branch. Calling "publish-signed" with the sbt-pgp plugin generates this pom file, but when I try to sync from bintray to maven central, I get this error message.

JohnReedLOL commented 7 years ago

Success! https://drive.google.com/file/d/0B1IimJ20gG0SVWdnRDM1R1N0Y2s/view?usp=sharing