search

JohnSmithDev / ISFDB-Tools

Tools to query a local copy of the ISFDB database
5 stars 1 forks source link

Possible regression: Mira Grant not being picked up properly as Seanan McGuire #12

Open JohnSmithDev opened 5 years ago

JohnSmithDev commented 5 years ago

Output from a new (not yet committed script):

./bulk_title_authors.py 2019 ... WARNING:root:No Twitter link(s) for http://www.isfdb.org/cgi-bin/title.cgi?2515634 http://www.isfdb.org/cgi-bin/ea.cgi?133814

  1. title_id=2515634, author_id=133814, gender_stuff=GenderAndSource(gender='F', source='human-names:Mira Grant') ...

This should be coming from Wikipedia.

Especially galling seeing this is an author_id I use in my tests :-(

JohnSmithDev commented 5 years ago

OK, that particular script isn't going through the same function path as the reports that use gender_analysis.py

I've done some refactoring that will allow it to use the code from gender_analysis.py (now moved to title_related.py) that should address this issue (and maybe a couple of the preceding ones.

I am slightly bothered that the gender determination code this code was calling isn't doing the depseudonymization, which I thought it was. Hopefully I can get to a point where there is a single clear entry point to the gender determination, that covers all the bases.

JohnSmithDev commented 5 years ago

Reopening because the commit that claims to fix this had the wrong number in the commit message :-(

As per prior comment, the original reported issue has been fixed, but I'm not 100% certain this is solved everywhere it needs to me, hence keeping it open for now.