search

JohnSundell / Files

A nicer way to handle files & folders in Swift
MIT License
2.53k stars 182 forks source link

Expose more standard Folders on iOS/tvOS #113

Closed clayreimann closed 3 years ago

clayreimann commented 4 years ago

More Folder API for iOS and tvOS

clayreimann commented 4 years ago

It would also be nice to get a current release of Files. Thanks for this convenient library!

JohnSundell commented 4 years ago

Great idea @clayreimann, and thanks for opening this PR. Do you mind also ensuring that the tests cover these new changes? After that's done, I'll merge this in and will make a new release 👍

clayreimann commented 4 years ago

@JohnSundell got the tests done. I'm not super happy about the Folder.documents test, so if you have suggestions about how to improve it I'm all ears. (maybe we should ensure that that folder exists first?)

Edit: Is there a way to create a Folder for a path that doesn't exist yet? (e.g. one that you want to create)

It's also strange that the buildbuddy build broke, but the other two passed. The test passed on my local machine too. I wonder what the subtle difference is between the platforms…

clayreimann commented 4 years ago

Following up again, I figured out a cleaner way to write the tests. Let me know if how things are being tested seems reasonable or if there's a way you'd prefer I'd test this change.

eralnar commented 4 years ago

Hey! Waiting for this to be released so I don't need to extend the library to get this folders available. Thank you for your job @clayreimann @JohnSundell

clayreimann commented 4 years ago

@canedo2 While we're waiting for Josh, you can use my GH fork as the source in XCode's package manager to get the patch

clayreimann commented 3 years ago

@JohnSundell are the tests here good?

0xifarouk commented 3 years ago

Any news?

JohnSundell commented 3 years ago

Replaced by https://github.com/JohnSundell/Files/pull/122, thanks for your work on this @clayreimann!