Closed maximkrouk closed 5 years ago
@maximkrouk Thanks for contributing, but you haven't made the code more "Swifty", you've only made it conform to your own personal code style - which I'm not interested in. Plus, you've added a ton of unnecessary whitespace. Closing this.
Well, got it, thanks for the feedback.
Really nice feedback, for now it's my second contribution and I made the same mistake in the previous one, now I understand the point and will be more attentive and respective to the owner styles.
That's great @maximkrouk! 🙌
Just tried to make code a little bit more swifty. Build should be failing because of swift5.1 I guess 💁♂️.
And what do you think about using
instead of
The first one seems more laconic I think c: One-line short expressions as well: