search

JohnSundell / Marathon

[DEPRECATED] Marathon makes it easy to write, run and manage your Swift scripts 🏃
MIT License
1.86k stars 78 forks source link

Danger #106

Closed cojoj closed 5 years ago

cojoj commented 7 years ago

Closes #102

Added Gemfile with our Ruby dependencies, updated swiftlint.yml, cause it had some issues with correctly checking files, simplified boddybuild_postclone, created very basic Dangerfile.

cojoj commented 7 years ago

Hahaha, @JohnSundell you'll be the bad guy reporting all the bad things 😂 Seems like it works. I'll have to add more stuff to Dangerfile, but it's nice it works out of the box ❤️

JohnSundell commented 7 years ago
1 Warning
:warning: Please provide a summary in the Pull Request description

Generated by :no_entry_sign: Danger

JohnSundell commented 7 years ago

Haha 😅 We should be able to configure that to say "DangerBot" or something.

cojoj commented 7 years ago

@JohnSundell to do so I'll need access to BuddyBuild or you'll have to create Bot and add it. I have account on BuddyBuild, so I guess you can invite me, but I guess I'll be able to finish this no sooner than Tuesday (going to the wedding 👰)

cojoj commented 7 years ago

@JohnSundell I'll kindly ask you to follow these steps and add the DANGER_GITHUB_API_TOKEN to Bot's build ENV. We shouldn't have any further changes in this PR as from now on buddybuild should handle everything correctly (Gemfile and Dangerfile are present). We may wan to create a special doc for our guidelines, but I don't think it's necessary as Danger will handle everything and report it, so it's way more convenient and one less thing to maintain. I'd rather take a look at other projects and see some Danger checks for which we can benefit as well, but I guess I'll just propose them (if I find anything) in #102.