search

JohnSundell / ShellOut

Easily run shell commands from a Swift script or command line tool
MIT License
876 stars 87 forks source link

localizedDescription for ShellOutError #14

Closed muukii closed 6 years ago

muukii commented 7 years ago

Hi, Thanks for the helpful library.

I think ShellOutError needs to improve printing. Currently, ShellOutError prints following.

let error: ShellOutError
print(error)
ShellOutError(terminationStatus: 1, errorData: 32 bytes, outputData: 0 bytes)

I want a more helpful description. I think to convert to string from errorData.

What do you think?

JohnSundell commented 7 years ago

Sounds like a plan 👍 Want to submit a PR?

muukii commented 7 years ago

@JohnSundell Thanks. I've submitted PR. Please check it.

16

JohnSundell commented 6 years ago

Implemented here https://github.com/JohnSundell/ShellOut/pull/20. New release including this patch coming soon 👍