JohnSundell / ShellOut

Easily run shell commands from a Swift script or command line tool
MIT License
870 stars 83 forks source link

Added `Handle` protocol to get asynchronous output #30

Open gwikiera opened 6 years ago

gwikiera commented 6 years ago

I've created a protocol Handle to handle command output asynchronously. All previously FileHandle arguments of shellOut methods have been replaced by Handle. FileHandle implements Handle so it's completely backward compatible. StringHandle converts Data output into String one.

It fixes #11.

iainsmith commented 6 years ago

This looks good. @JohnSundell would you like any changes before merging this?

We could then add the implementation from @SteveBarnegren in #22 so that users can use FileHandle.standardOuput & FileHandle.standardError. I've tested out #22 locally.

private extension FileHandle {
     var shouldBeClosed: Bool {
         return self !== FileHandle.standardOutput &&
             self !== FileHandle.standardError &&
             self !== FileHandle.standardInput
     }
 }

extension FileHandle: Handle {
    public func handle(data: Data) {
        write(data)
    }

    public func endHandling() {
        if shouldBeClosed { closeFile() }
       // alternative using naming from #22
       // if !isStandard { closeFile() }
    }
}