Closed iainsmith closed 4 years ago
TL;DR. I’ve updated the PR to remove StringHandle
. IMO this gives us the best of all worlds.
So it seems like there are a few things to discuss here.
I’d like to propose we can move forward by:
StringHandle
type?
We can always add StringHandle in a future PR if we want to.
Here is an example of how I'm using the Handle protocol in [swift-docker] for streaming long running docker commands: (https://github.com/iainsmith/swift-docker/blob/7653086b109033cb47a63c175e90c1b7f80002f2/Sources/SwiftDockerLib/Logging.swift#L22L37)
I also realised the original title of the PR wasn't that helpful 🤦‍♂️
Anything that needs to be done for this? :)
Closing due to lack of feedback.
đź‘‹ @JohnSundell.
This PR is a combination of work from @gwikiera & @SteveBarnegren (Added as a coauthor to the appropriate commit). If we merge this PR we can close #30 & #23.
Changes
Partially Reverted
31 - Package.swift. The tools comment should remain at 4.0 otherwise consumers can't build ShellOut with swift 4.0