Change shell from bash to zsh

JohnSundell / ShellOut

Easily run shell commands from a Swift script or command line tool

MIT License

870 stars 83 forks source link

Change shell from bash to zsh #51

Open tapi opened 4 years ago

tapi commented 4 years ago

Since MacOS now ships with zsh I think it would make sense to change the shell used by ShellOut to match. I was just bitten by an issue where file globbing behaviours were different between the two and debugging it made no sense since it worked when run manually.

Alternatively the shell could be made configurable. Happy to make the change, just wanted to start the discussion first.

ghost commented 3 years ago

I hit this recently too. Agree it would be good to be able to assign or override the launchPath and similar used by the underlying process to better support zsh.

However, in the mean time I have just added an abstracted Process class named ZSHProcess which will ensure it uses the things I need.

leoidiaz commented 2 years ago

Didn't know there was an open issue for this. I submitted a PR for a quick way to add this option last month. Don't know if it will ever get merged but feel free to fork off my version if it's of any use!