search

JohnSundell / SwiftPlate

Easily generate cross platform Swift framework projects from the command line
MIT License
1.77k stars 88 forks source link

License put in by default #19

Closed codeOfRobin closed 7 years ago

codeOfRobin commented 7 years ago

It looks like the generated files have the MIT License put in by default at the top of all files. Though it doesn't really make a difference to my org (we're open sourcing most of our stuff), people might have a problem with it. screen shot 2016-11-23 at 4 42 27 pm

JohnSundell commented 7 years ago

Yeah, we should probably ask when SwiftPlate is run what license that the user wants to use, and add that both to the LICENSE file and as a header to all source files.

kiliankoe commented 7 years ago

Do source files really need a license header? Isn't a LICENSE file enough? Just feels so unnecessary 😕

codeOfRobin commented 7 years ago

I kinda agree with @kiliankoe . Can't we just us the XCode default of 

//
//  <File Name>
//  <org name>
//
//  Created by <Dev name> on 22/08/16.
//  Copyright © 2016 <Org Name>. All rights reserved.
//
JohnSundell commented 7 years ago

Yeah, the Xcode defaults should be enough actually 👍 (if people want to add a license header to the source + test file they can easily do so after SwiftPlate has generated them anyway)

JohnSundell commented 7 years ago

Resolved by https://github.com/vknabel/SwiftPlate/commit/9fce473ec3e944f38a66b3f3a39980dd76fd66bf