search

JohnSundell / SwiftPlate

Easily generate cross platform Swift framework projects from the command line
MIT License
1.77k stars 88 forks source link

Optional Gather coverage data #30

Closed adellibovi closed 7 years ago

adellibovi commented 7 years ago

Hi John, First of all, thanks for this tool, it has been very helpful for me. Do you think that an option to enable the "Gather coverage data" for all the testing targets would be useful? Does it suit in this project? If so, I would like to work on that and prepare a PR.

JohnSundell commented 7 years ago

@adellibovi Sounds like a great idea! 👍 I'd actually be open to leaving it on per default, there's no real downside to gathering coverage data, right?

adellibovi commented 7 years ago

@JohnSundell totally agree! So, just to understand the directions for this feature: would this be an argument of the command only, both question and argument, or something implicit?

JohnSundell commented 7 years ago

@adellibovi I would say, just do it implicitly for now. If someone doesn't want code coverage to be generated they can just go into Xcode and un-tick the box 😄

adellibovi commented 7 years ago

I'm closing this since the PR got merged :)

JohnSundell commented 7 years ago

Great work @adellibovi! 🎉