Closed instarevealed closed 7 years ago
Hello instarevealed,
I have checked out your site and I see what you're talking about. I can see that the breakpoints did try to save, however the values weren't passed in. I'm not sure why, I cannot seem to replicate the issue on my end.
Right click on the table editor page and inspect the console log while you try to add breakpoints / save the table and see if you get any errors.
Let me know if there is an error, this will hopefully push me in the right direction.
Thanks John
Thanks for the reply John.
I tried following these instructions and there are no Javascript errors raised. Any other ideas? I have tried updating the table in both Firefox and Chrome.
Since you cannot replicate it, I can give you login access to the Wordpress Dashboard if you want?
Thanks, Teri
On Fri, Dec 30, 2016 at 1:36 PM, John Tendik notifications@github.com wrote:
Hello instarevealed,
I have checked out your site and I see what you're talking about. I can see that the breakpoints did try to save, however the values weren't passed in. I'm not sure why, I cannot seem to replicate the issue on my end.
Right click on the table editor page and inspect the console log while you try to add breakpoints / save the table and see if you get any errors.
Let me know if there is an error, this will hopefully push me in the right direction.
Thanks John
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JohnTendik/jtrt-tables/issues/29#issuecomment-269812981, or mute the thread https://github.com/notifications/unsubscribe-auth/AXo35ygXnsApmfZDr6RVYfTEhN96hG2rks5rNV06gaJpZM4LWDDq .
Hey Teri,
If you could give me access so I could do some testing that would help out a lot. You can create a temp account for me and delete it when i'm done.
Don't post the credentials here though, on my github profile my email is available, email me so its private and away from public eyes.
Thanks John
Hello Teri,
After some testing, I was able to figure out the issue, I think. I'm not exactly sure if this is the issue but I was able to reproduce this issue by doing the following:
I was selecting the top header (A, B, C) as demonstrated in the following picture:
Can you try selecting the first row ( header ) value instead of selecting the entire column like so:
I will definitely include a fix for this but in the meantime can you please confirm that this is the problem and not something else?
Thank you for the support and feedback! John
Hi John
Yes - clicking on Row 1 (Header) works and the changes are saved.
Thank you so much for your follow up and helping me resolve this. The table is up and working on the site.
Teri
On Mon, Jan 9, 2017 at 1:52 PM, John Tendik notifications@github.com wrote:
Hello Teri,
After some testing, I was able to figure out the issue, I think. I'm not exactly sure if this is the issue but I was able to reproduce this issue by doing the following:
I was selecting the top header (A, B, C) as demonstrated in the following picture: [image: issue1] https://cloud.githubusercontent.com/assets/4714913/21780863/f66ef3c2-d661-11e6-9ff9-ec77a4cec9ab.jpg
Can you try selecting the first row ( header ) value instead of selecting the entire column like so: [image: issue2] https://cloud.githubusercontent.com/assets/4714913/21780891/1232a16c-d662-11e6-887a-2896d2aa559f.jpg
I will definitely include a fix for this but in the meantime can you please confirm that this is the problem and not something else?
Thank you for the support and feedback! John
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JohnTendik/jtrt-tables/issues/29#issuecomment-271389290, or mute the thread https://github.com/notifications/unsubscribe-auth/AXo3527LzEjymkeZ1cQhRT4qlobn_QNeks5rQpAVgaJpZM4LWDDq .
Hey Teri,
Perfect :) I will include a fix for this in the update, if you run into any more issues or have any questions feel free to contact me.
Thanks John
I just upgraded to the newest version of the plugin and found that the breakpoints seem to be broken.
When I'm selecting a column and applying the breakpoints, they don't seem to be printed in the HTML code within the table (on the public-facing page). Here's an example URL: http://instarevealed.com/instagram-hashtag-sheets/
And here is a screenshot of the HTML code showing that the "th" element has an attribute of data-breakpoints="" - I'd assume it should show one of the values that I've saved in the WP dashboard.
Can you please check this and let me know if you're able to replicate the issue or any suggestions on what else I can try?
Thank you! :)