Table jumps, hides toolbars each time a table cell is selected

[Seamate]

Hello John, I upgraded to the latest version of your plugin as soon as I was notified in my dashboard that one was available. However, when I tried to create a table, I observed that each time I selected a cell, the entire toolbar area jumps upwards out of sight, so that I have to scroll up to see and use a tool, e.g. borders. This makes it very tiring working with tables that require lots of formatting or the use of the toolbar, especially tables with large data. Please try to fix this

Also, tables that have been published still appear as draft on the list of tables. I noticed this since the penultimate upgrade.

Btw, thanks for the shortcode support feature

[ghost]

@JohnTendik I've duplicated the issue of draft tables still showing as draft on the table. We should also ensure in fixing this that the draft button is removed from subsequent updates the same way a page or post would.

@Seamate What browser and WordPress version are you using? And have you observed any regression on your published tables as well or is the issue only in the editor?

[Seamate]

I use Firefox and Wordpress version 4.9.4. The issue is not present in published tables. It seems to only affect the editor.

Another issue I found is that the first row of every NEW table is treated as a header and thus displayed as bold. This behaviour could misrepresent data. Maybe I should post this as a new issue?

[Seamate]

The first row treated as header, I found, isn't really an issue, as one could simple leave the first row blank to avoid an unnecessary emphasis on text. I guess that's the intended behaviour. I'm sorry for the inconveniences bro

[JohnTendik]

@Seamate Thanks for bringing this up. I was able to reproduce the tables appearing as drafts as well. I will take a look into why this is happening. However, the jumping up and down I'm not sure I've come across this before. @jodylecompte were you able to reproduce this at all? @Seamate If you open up the console, do you see any errors at all? How many rows does your table have? Can you provide a picture of the issue at all it would help narrow down where the problem may be arising.

Also as for the first row being treated as headers that's because as they are being built, the first row is made into th table headers. This is necessary because of the responsive scripts needing to rely on the header attributes. =) I have been asked for a headerless table feature, I will look into whether or not this is possible.

Thanks JT

[JohnTendik]

Nevermind, I think I see the issue lol :) the page scrolls down correct? I will take a look at this as well.

[Seamate]

Exactly bro. The page scrolls down when a cell is clicked on

[JohnTendik]

Okkey I believe this is connected to the latest Handsontable update that I made. I think it may be trying to center the page when you click the cell. Ill take a look and see if I can disable that(if thats the case)

[Seamate]

Hello John, I think I saw something that might help you narrow down the problem of page scrolling down on cell click. At the bottom left corner of the page, something doesn't seem very right. It is like a text box that can be increased and reduced in sized by dragging the right bottom corner. Take a look at the image below. Please I also wanted to ask if it would be possible to add borders to all cells, rows and columns at once, as an additional option to the existing border styles on the table editor? Or should I make this request in a new topic? Thanks for your time bro

[JohnTendik]

@Seamate Hmm thats interesting. I'll take a look at that textarea lol, it definitely should not be visible. We did some testing and I don't think its handsontable so hopefully this will lead us somewhere.

Also as for the borders to all cells, rows, cols, I will look into adding this for the next release :) It has been asked before, I will spend some time today and try and come up with a solution.

[Seamate]

Thanks bro. The "text area" became very visible when I collapsed the dashboard toolbar.

And thanks for the borders on all cells, rows and columns which you plan to add in the next release. I am anticipating it, and will save the bulk of my work with tables till the next release. It will make my life much easier.

[JohnTendik]

@Seamate I released an update last night. Let me know if it fixed your issue. Also I fixed up the borders a bit, so now when you multi select it will add borders individually to cells which makes much more sense :)

Closing for now but let me know if you have any issues still.

Thanks

JT

[Seamate]

Thanks for giving me the option to add borders to all the cells on my table with a single click. That would save me a lot of time. Unfortunately, however, the issue of page scrolling on cell click is still there, and saved tables still appear as drafts, at least from my own end. I don't know if anyone else can reproduce these issues on their end.

Thanks for the efforts so far John.

[JohnTendik]

@Seamate try clearing your cache. It was a CSS only fix so you may have to shift+ctrl+f5 to hard reload the page. Your browser may have cached the old version of the CSS. Let me know if that still doesn't solve it and I'll re-open the ticket and look further :)

Thanks JT

[JohnTendik]

Oh as for the tables appearing as drafts, yeah I figured that out as well. Its because I'm submitting the form after I do my calculations, and I believe the default for the submit may be the save draft button. I will get this fixed up in the next release probably.

[Seamate]

I have cleared my cache and done everything necessary to to eliminate the possibility of the issue appearing only on my own end, including using a clean, new browser and reverting to the default Twenty Seventeen theme, even though I had decided it isn't a theme or plugin issue since you have been able to reproduce the problem yourself. Nevertheless, the problem persists.

Before the last plugin update which attempts to fix the issue, the page would scroll down to reveal the little "text area" at the bottom left area of the page. Now, with the "text area" gone following the update, the page scrolls UP instead to display the area above the table editor.

[JohnTendik]

Hehehe jeez :D So the issue is handsontable is adding that textbox to the page for the copy paste feature. Not sure why, dont ask me lol :) Anyway, because it was at the bottom on each click of the cell, it was pushing the page down. If I hide that box, the copy paste feature no longer works :( So I kinda just pushed it out of the page, but I believe I have the "top:" set to 0, meaning its at the top. I guess not that the box is at the top of the page, the page scrolls up :D hahah I will try to fix this. Bugs like these make me laugh.

Thanks! Jt

[Seamate]

Sure bro. Crazy bugs that seem to have a mind of their own. I, and I believe, a lot more other users can cope with it now that we can apply borders to all cells in one click. We don't need so many cell clicks to get a table done.

While you work on the solution, there's something else that seemed quite easy for you to implement on your tables; and that is shortcode support. I'm using a commercial LMS plugin that forms the core of my project, and even though shortcode support is crucial to plugins of this nature, the plugin's developer doesn't seem to be ready to add this feature in the near future. I'm thinking something, but pls don't ask me...yet. Lol :) Pls take a look at this issue https://github.com/Automattic/sensei/issues/2035

[JohnTendik]

Hey @Seamate, shortcode support has been recently added to the plugin by @jodylecompte You should be able to use shortcodes within the table cells.

[Seamate]

I know that. And it came at a time I needed it most. I'm talking about a commercial plugin that's very crucial to my project which doesn't support shortcodes in it's quiz section. Maybe you could create and extension that enables that for a little fee. A lot more people should find it useful, considering that it's an LMS plugin.

Now, this issue is becoming so off-topic. :(

[Seamate]

Hello John, I noticed also that it's impossible to edit cell data on the tables. You can only override data but not edit them as the page jumps each time you double click on a cell to edit. The double click function to edit cell data used to work before the jump issue surfaced. So please look into this as well. Thank you

[Seamate]

Hi John, It's been a while since we last saw your traces here. Hope you are good. And please, what's the update on the plugin?