search

JohnTitor / ctest2

Automatic testing of FFI bindings for Rust
https://crates.io/crates/ctest2
Apache License 2.0
22 stars 20 forks source link

Add support for long double #30

Closed GuillaumeGomez closed 2 years ago

GuillaumeGomez commented 2 years ago

Needed for https://github.com/rust-lang/libc/pull/2565.

GuillaumeGomez commented 2 years ago

ping @JohnTitor

JohnTitor commented 2 years ago

Looks fine, could you also add a test case here? https://github.com/JohnTitor/ctest2/tree/master/testcrate/src

GuillaumeGomez commented 2 years ago

From what I can read, it's supposed to compare the rust equivalent, however long double has no equivalent in Rust. So: how can I add a test for a type which doesn't exist in rust?

JohnTitor commented 2 years ago

I wanted to ensure that it works fine by replicating code from the above libc PR, doesn't it make much sense? If not, I'm fine to merge as-is.

GuillaumeGomez commented 2 years ago

I can give it a try at least.

GuillaumeGomez commented 2 years ago

Let's see how it goes now. :3

GuillaumeGomez commented 2 years ago

@JohnTitor Does the test looks ok to you?

GuillaumeGomez commented 2 years ago

Thanks for the release! :)