Open CraftSpider opened 2 years ago
Could you resolve merge conflicts? And it seems some structs' fields aren't marked as pub, is it intentional?
Given the new arm code also uses the underscores, I'm leaning towards reverting that change. I'll spend some time writing up the manual implementations for the long arrays also, to fix the 1.33 build.
Any other review requests for this? I'm not sure why the test failed, but it doesn't look immediately related. If it is, can I get a pointer in the right direction?
Sorry for the delay! The problem is that ctest2 uses old rustc's crates to parse and generate code. Maybe there is an unsupported syntax (on older rustc) on the changes but I cannot find what it is 🤔
__
onx86_thread_state64_t
, I went off of the fact that the structs are defined both with and without in the header, and that it adds a lot of unnecessary noise.