search

JohnUUU / code.pyret.org

Website for serving Pyret to folks.
Other
0 stars 0 forks source link

Color Fix + Basic Testing Framework #2

Closed eyanje closed 3 years ago

eyanje commented 3 years ago

I encountered an issue with rendering a single bar chart, so this pull request adds the color field to BarChartSeries.

To help find similar errors, this pull request also adds an extra .arr file to test-util/pyret-programs/charts which tests bar chart functionality. Most of the tests are extremely basic at the moment, as they only check to see if the charts render and don't check for correctness.

(In retrospect I should have split these up.)

Note: If the charts don't render, the test actually hangs. Hopefully this can get fixed, but I doubt it will because Pyret can't access the underlying asynchronous framework.

eyanje commented 3 years ago

We should probably merge this as soon as it's good. It's a little difficult to develop the other methods without it.

(Also, somewhat unrelated, but can you enable Issues for this repo? I want to track code issues separately from our API design docs.)

JohnUUU commented 3 years ago

Yeah, that makes sense. Somewhere along the line I completely forgot that this was supposed to just be the testing branch. In fact, I think the current version is already good enough to merge. Also Opening Issues right now 👍