So I recognised that the CI process was slightly flimsy recently and decided to do something about it, in particular, tests weren't running within the pipeline, which is borderline unforgivable for a CI, this, I recognised, was influencing my opinions around writing tests, because I didn't want to write tests because they weren't running, breaks in the build recently spurred me to decide to finally fix the problem. This then ran me into another issue, where the docker builds that were present in the pipeline were returning 0 exit codes, but the container itself was actually broken. It turns out this was a simple problem, I hand't included valid secrets in the Travis CI keychain, and instead of checking this first, I overengineered for 2 days before checking it. Overall, I have come out with a stronger pipeline though, one that we can pin docker and docker-compose on, and fixed a few other latent issues. This PR does not merge frontend tests, because they require Java in the build, which I haven't gotten to, this will be solved in the next, separate PR.
JohnVonNeumann
commented
5 years ago
So I recognised that the CI process was slightly flimsy recently and decided to do something about it, in particular, tests weren't running within the pipeline, which is borderline unforgivable for a CI, this, I recognised, was influencing my opinions around writing tests, because I didn't want to write tests because they weren't running, breaks in the build recently spurred me to decide to finally fix the problem. This then ran me into another issue, where the docker builds that were present in the pipeline were returning 0 exit codes, but the container itself was actually broken. It turns out this was a simple problem, I hand't included valid secrets in the Travis CI keychain, and instead of checking this first, I overengineered for 2 days before checking it. Overall, I have come out with a stronger pipeline though, one that we can pin docker and docker-compose on, and fixed a few other latent issues. This PR does not merge frontend tests, because they require Java in the build, which I haven't gotten to, this will be solved in the next, separate PR.