[Android March 2016] Week 1 : Instagram Client

[JohnWhisker]

@coderschoolreview

[JohnWhisker]

@hoanle

[chug2k]

:+1: thank you for your submission. The goal of this homework was to teach you RelativeLayout, ListView, networking with APIs, and loading remote images. These concepts are the foundation of nearly every app.

A few notes after checking out the code:

• Your assignment looks quite nice! Good job on the styling and placeholder images.
• Please be more consistent about the names of classes and files. For Java, you should always use names like: CommentActivity.java instead of comment_activity.java. Classes should be capitalized, and use CamelCase. I know this does not seem very important - but imagine: sO mUCH haRDEr TO READ This Way.
• Same goes for variables and methods - both should start with lowercase. Uppercase variables are for classes. (Except for constants like CLIENT_ID, your way is correct.)
• I think your fletchPhotos and fetchTimelineAsync methods are the same. You can just call one, instead of making two separate ones.
• Great job with the Comments Page!
• Great job with the Profile page too! Amazing.

Overall, you did a lot of great things with this assignment and your styling is pretty good. However, I will encourage you to be a little more "clean" in your code. That way it will be easier to understand. It takes time to learn how to make code "clean", but for you, I think the two biggest ones:

• Clean naming convention
• Removing duplicate code.

You can read a detailed Project 1 Feedback Guide here which covers the most common points we see for this project, if you'd like to evaluate yourself further.

[JohnWhisker]

Thanks you for the reviewing. It's very helpful. I'm working on fixing it

[JohnWhisker]

I just cleaned my code, and merge 2 quite similar functions into 1 funtion with switch.