search

JohnXLivingston / peertube-plugin-livechat

GNU Affero General Public License v3.0
90 stars 26 forks source link

Ban User Who Isn't Actively in the Room #526

Open vencabot opened 2 months ago

vencabot commented 2 months ago

Is your feature request related to a problem? Please describe. When using moderation tools for a room participant who has left the room, attempts to change Affiliation result in, "Sorry, something went wrong when trying to change affiliation." I believe this is because, at this point, they seem to have no JID -- only a 'nickname' and 'occupant id'.

Describe the solution you'd like It would be nice if user JIDs could be saved and recalled even if they aren't actively in the room. I presume that being able to do so would address this issue. Can they not be saved along with the occupant ID?

Describe alternatives you've considered The workaround would seem to be to ban a user the next time they show up to the chat.

Additional context It took me a while to figure out how to ban users, and even after looking through the documentation I didn't really see any information regarding this. Since this is a pretty common moderation necessity, maybe UI improvements could be considered in the future? I presume that assigning the outcast' role is what causes users to no longer be able to send messages to the chat (?). If so, maybe "banned" would be a better name for the role.

Thank you for everything that you've done to make this livechat plugin so usable and useful for streamers, moderators, and viewers!

JohnXLivingston commented 2 months ago

They are definitively improvements to be done in the documentation, and in the UX/UI.

"outcast" is a ban, yes. This vocabulary comes directly from the XMPP specification. And i agree that it is not very understandable.

As a first step, would a "ban user" action in the message's action menu help? So you can ban the user directly when you see their message?

I know that the main ConverseJS maintainer plans to add actions in the occupant modal. That could also help. But i don't know when it will be available.

vencabot commented 2 months ago

As a first step, would a "ban user" action in the message's action menu help? So you can ban the user directly when you see their message?

Yes, I think this would be a good idea. Interesting about the 'outcast' language! Maybe what I should do is raise an issue like this to Converse.js rather than here. I don't really have any experience with Converse.js, so I don't know which features are Converse and which are unique to the Live Chat plugin. Before I raise future issues, I'll try to get accustomed to Converse.js and make sure I raise upstream-related issues in their proper place.

Thank you for everything, sir!

JohnXLivingston commented 2 months ago

You can continue to open issues here. There are a lot of customization for the livechat plugin, so it is not easy to tell if it concerns ConverseJS or not.