search

Johnathan / nova-trumbowyg

MIT License
24 stars 9 forks source link

Hardcoded path to icons.svg #16

Open martin-ro opened 4 years ago

martin-ro commented 4 years ago

Is there a better solution then to hard code the path to icons.svg? When deploying assets to for example S3 the icons can't be found.

Or maybe a setting to set a custom path.

Johnathan commented 4 years ago

@martin-ro Thanks for the report. I'm not sure about this to be honest because the path to icons.svg comes from the trumbowyg package itself but it's definitely something that needs to be addressed.

martin-ro commented 4 years ago

There is an option to change the path to the icons in trumbowyg. Not sure if that can be used to fix the issue.

Johnathan commented 4 years ago

And a prop on vue-trumbowyg which is used underneath so definitely seems possible. I'll try and get a look at it this week, if you need it sooner feel free to make a PR.