Open Johnchiahk opened 1 year ago
No details provided by team.
[The team marked this bug as a duplicate of the following bug]
Duplicates are not case sensitive
Reroll does not detect duplicates when there are same inputs, but different casings. It is reasonable to expect that two
Characters
with the sameName
refer to the sameCharacter
even if their names are not in the same casing. For example,make char Bob
followed bymake char BOB
creates two differentCharacters
with NamesBob
andBOB
respectively
[original: nus-cs2103-AY2223S2/pe-interim#1741] [original labels: severity.Medium type.FeatureFlaw]
[This is the team's response to the above 'original' bug]
Thanks for spotting this!
This issue was actually brought up during the PE-D. While it is true that we did not account for it originally, our team thought about it and felt that this was not something that needs fixing (hence it was not mentioned as a feature flaw in the DG). For example, in the context of the game, one may have an item named
iron sword
and a separate glitched item namediRoN sWoRd
.Hence, this behaviour is expected in the context of the app.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
The likelihood of "John Cena" and "john Cena" be the same person is not low, and the user may have forgotten that his name already exists, and input his name into the app with a slightly different variation, such as not making their first letter capital.
A suggestion would be to convert all the names in the app to lower case internally, and then see if there is a name that already exists. For example, John Cena can be converted to "john cena" in the program internally, and when "john Cena" is typed in by the user, "john Cena" is converted to "john cena" internally, and one can detect the duplication.