Johnchiahk / pe

0 stars 0 forks source link

Unable to exit when in edit mode #7

Open Johnchiahk opened 1 year ago

Johnchiahk commented 1 year ago

Screenshot (1483).png

A user may need to go in a hurry and exit his app quickly. However, the app would not allow one to exit until he press 'b' or 'back'. This can cause inconvenience to users. Someone may not be able to exit his app on time and another person may sabotage whatever he has done by editing random stuff. The severity of this may even be medium if that's the case.

A suggestion would be to allow the user to exit the app even while in edit mode.

nus-se-script commented 1 year ago

Team's Response

Currently, both back and exit along with their short form commands are fully functional features within Reroll, and so the user is capable of exiting Reroll from the edit page. Having to key in back before exit does not seem to garner the issue of someone coming in and sabotaging the inputs before they are able to exit in time, as even with a single exit command the program is still susceptible to other people editing random stuff. Thus for the purposes of this iteration, the features are complete and achieve a relatively quick command speed for the purposes of Reroll. Furthermore there is another workaround to directly exiting from the edit page, that being to click the close button on the top right. However, this is a valid improvement for further speeding up the CLI of Reroll that could be introduced in a future iteration.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]