Johni0702 / BetterPortals

A Minecraft Mod which adds see-through portals usable without any loading screen
GNU General Public License v3.0
107 stars 15 forks source link

Vivecraft third-person / MR mode not compatible #388

Open Johni0702 opened 5 years ago

Johni0702 commented 5 years ago

Low priority continuation of https://github.com/Johni0702/BetterPortals/issues/122

These need additional handling:

Until then, portals are disabled for the third-person pass (ref).

Techjar commented 4 years ago

So for clarification, the "first person" render pass (which is still a third render pass, just from the center HMD perspective) works, correct?

Johni0702 commented 4 years ago

So for clarification, the "first person" render pass (which is still a third render pass, just from the center HMD perspective) works, correct?

Yes (at least at time of issue creation, haven't tested since). There should be no issue with a third render pass (or really any number of render passes), it's just the depth buffer and third-person offset which aren't working yet (the latter being why I completely disabled BP's rendering during the third-person pass for now).

Edit: Reading one of my comments at the time, there's also an issue with BP's occlusion culling which I forgot to list in the above issue (just added it), that's another reason why BP's rendering is disabled during the third-person pass.